Skip to content

Avoid VoiceOver interruptions from hidden text updates #59117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sbuggay wants to merge 1 commit into from
+8 −0
Closed

Avoid VoiceOver interruptions from hidden text updates #59117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/react-native/React/Fabric/Mounting/ComponentViews/Text/RCTParagraphComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,14 @@ - (void)updateState:(const State::Shared &)state oldState:(const State::Shared &
const auto &newData = std::static_pointer_cast<const ParagraphShadowNode::ConcreteState>(state)->getData();
const auto &oldData = std::static_pointer_cast<const ParagraphShadowNode::ConcreteState>(oldState)->getData();
if (!newData.attributedString.isContentEqual(oldData.attributedString)) {
// Changes inside a hidden subtree must not interrupt VoiceOver on visible content.
UIView *view = self;
while (view != nil) {
if (view.accessibilityElementsHidden) {
return;
}
view = view.superview;
}
UIAccessibilityPostNotification(UIAccessibilityLayoutChangedNotification, nil);
}
}
Expand Down
Loading