You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
RDKEMW-25259: speechsynthesis firebolt api implementation - #17
Reason for change: new tts firebolt api integration
Test Procedure: Mentioned in ticket
Risks: Low
version: minor
Signed-off-by: kumar <kumar_Karuppiahyogarajah@comcast.com>
The reason will be displayed to describe this comment to others. Learn more.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Reason for change: new tts firebolt api integration
Test Procedure: Mentioned in ticket
Risks: Low
version: minor
Signed-off-by: kumar <kumar_Karuppiahyogarajah@comcast.com>
A client created with a null connection callback does not refresh m_ttsEnabled when creating a session. Until a separate state query or change event occurs, speak() rejects requests as disabled even if voice guidance is enabled. Refresh the cache regardless of whether there is a callback to notify.
Forward synthesis failures as terminal speech errors
A synthesis failure is discarded instead of being forwarded as a terminal speech error. The private client only removes speech-ID mappings and notifies the application in terminal-event handlers, so a failed synthesis leaves its request tracked and the application receives no completion or error notification. Translate this event to an appropriate terminal error callback, adding a synthesis-error path if needed.
Reason for change: new tts firebolt api integration
Test Procedure: Mentioned in ticket
Risks: Low
version: minor
Signed-off-by: kumar <kumar_Karuppiahyogarajah@comcast.com>
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Unresolved defects break a supported Firebolt build, risk deadlocks and undefined behavior, expose utterance text in logs, and report API success without valid results.
The new public structured-voice API forwards directly to this method, but it returns TTS_OK without retrieving voices or updating the caller's vector. On JSONRPC, callers therefore see an apparently successful empty or stale voice list even though the existing overload can enumerate voices. Implement the conversion, or report TTS_FAIL while this overload is unsupported.
Query enabled state even without a connection callback
ttsclient/TTSClientPrivateNativeFirebolt.cpp:201
With a null connection callback, createSession skips the initial enabled-state query. m_ttsEnabled therefore remains false, and speak() rejects requests with TTS_NOT_ENABLED even when voice guidance is enabled, until a state-change notification arrives or the caller explicitly queries the setting. Fetch the state independently of whether a notification callback is registered.
synthesisFailed is a terminal utterance failure, but this branch drops it without notifying the client. The request consequently remains in m_requestedSpeeches, whose entries are removed by terminal callbacks, and the application never receives a completion/error for that speech. Translate this event to an appropriate existing terminal-error callback or add a synthesis-error callback that also removes the request mapping.
Reason for change: new tts firebolt api integration
Test Procedure: Mentioned in ticket
Risks: Low
version: minor
Signed-off-by: kumar <kumar_Karuppiahyogarajah@comcast.com>
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Unresolved build failures, undefined behavior in logging, and callback deadlock risks prevent supported configurations from compiling or operating safely.
Reason for change: new tts firebolt api integration
Test Procedure: Mentioned in ticket
Risks: Low
version: minor
Signed-off-by: kumar <kumar_Karuppiahyogarajah@comcast.com>
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
Unresolved critical defects break the legacy Firebolt build, introduce undefined behavior in logging, and allow application callbacks to deadlock the event thread.
Reason for change: new tts firebolt api integration
Test Procedure: Mentioned in ticket
Risks: Low
version: minor
Signed-off-by: kumar <kumar_Karuppiahyogarajah@comcast.com>
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
The change breaks the legacy Firebolt build and introduces critical runtime defects, including undefined behavior in logging, callback deadlocks, and inconsistent connection state.
Reason for change: new tts firebolt api integration
Test Procedure: Mentioned in ticket
Risks: Low
version: minor
Signed-off-by: kumar <kumar_Karuppiahyogarajah@comcast.com>
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Callback dispatch can dereference freed clients after concurrent unregistration, and voice-change notifications bypass the new vector overload, dropping voices and metadata.
TTSLOG_INFO("Got voice_changed event from TTS Manager %p, new voice count = %zu", this, newVoices.size());
m_connectionCallback->onVoiceChanged(newVoices[0].name); /* currently sending only the first voice */
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: new tts firebolt api integration
Test Procedure: Mentioned in ticket
Risks: Low
version: minor