Repository navigation
http: apply [HtmxResponse] headers before the action runs - #116
Merged
Merged
Conversation
The attribute set its headers in OnResultExecuting, after the action had run, so it replaced the values that the action set in code, such as a Response.Htmx(htmx => htmx.Retarget(...)) call for validation errors. Code inside the action is more specific than an attribute, in the same way that an action's attribute already wins over the controller's. The attribute is now an action filter and a page filter, and sets the headers before the action or page handler runs. The code can replace or remove them, and the action's attribute still wins over the controller's.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HtmxResponseAttributenow implementsIActionFilterandIPageFilterinstead ofIResultFilterand sets its headers before the action or page handler runs.Response.Htmx(...)orResponse.GetHtmxHeaders()now take precedence, and code can remove a header that the attribute set. The action's attribute still wins over the controller's.