Repository navigation
tag-helpers: reject hand-written attributes that the Tag Helpers render - #115
Merged
Merged
Conversation
hx-val-*, hx-header-*, and hx-request-* silently replaced a hand-written hx-vals, hx-headers, hx-request, or hx-config on the same element, so its values were lost without a warning. On HTMX 4.x, a hand-written attribute and a generated one with modifiers were both rendered. The Tag Helpers now throw InvalidOperationException, as the URL Tag Helper and the built-in Anchor, Form, and Form Action Tag Helpers do when asp-* attributes would replace href, action, or formaction. The check does not depend on the bound values, so a conflict in the markup fails on the first render rather than only for some data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.