Repository navigation
config: expose collection options as read-only lists - #114
Merged
Merged
Conversation
ResponseHandling was an IList because a removed <response-handling> Tag Helper appended rules to it, while the other collection options were arrays. All five are now IReadOnlyList<T>. Configuration JSON is cached until a property is assigned, so adding or replacing items in place was silently ignored after the first render. A read-only list rules that out at compile time, and arrays, lists, and collection expressions can still be assigned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ResponseHandlingwas anIList<T>because a removed<response-handling>Tag Helper appended rules to it, while the other collection options were arrays. All five are nowIReadOnlyList<T>.Configuration JSON is cached until a property is assigned, so adding or replacing items in place was silently ignored after the first render. A read-only list rules that out at compile time, and arrays, lists, and collection expressions can still be assigned.