Repository navigation
http: escape non-ASCII characters in HX-Trigger and HX-Location JSON - #109
Merged
Merged
Conversation
JSON written into response headers used the encoder meant for HTML
attributes, which leaves all Unicode ranges unescaped.
Response headers allow only ASCII, so a non-ASCII event name, event
detail, or HX-Location option, such as
TriggerEvent("saved", new { Name = "Привет" }), failed with "Invalid
non-ASCII or control character in header" and the request returned 500.
This is a regression from 1.2.2.
Write header JSON with the default encoder, as 1.2.2 did. HTML
attributes keep the encoder that preserves Unicode characters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.