Skip to content

Say "minor units", not "base units", for the smallest token denomination - #211

Merged
mikemaccana merged 1 commit into
mainfrom
claude/peaceful-ptolemy-oh26c8-minor-units
Nov 10, 2026
Merged

mikemaccana merged 1 commit into
mainfrom
claude/peaceful-ptolemy-oh26c8-minor-units

Conversation

@mikemaccana

Copy link
Copy Markdown
Collaborator

What changes

"Base unit(s)" becomes "minor unit(s)" wherever it means the smallest denomination of a token. That covers doc comments, code comments, READMEs and CHANGELOGs in 53 files across lending, managed fund, perpetual futures, token swap and betting market, in every framework.

The replacement also covers:

  • Hyphenated forms: "sub-base-unit" becomes "sub-minor-unit".
  • Split phrases: places where a line break separated "base" from "units".
  • The order book README: "base units" meant the BASE token's minor units there, so it now says "BASE minor units" and "QUOTE minor units".

"Base" where it names the base asset of a trading pair, as in GOLD/USD, is unchanged. That covers the order book's base/quote, the prop AMM and the managed fund.

Why

The solana-finance plugin (skills/solana/SKILL.md) says: "a minor unit is the smallest denomination, the raw integer programs operate on - cent, penny, sen, lamport. Use these terms; do not say 'base units'." In finance, "base" already names the first asset of a pair, so "base units" reads as units of that asset.

Testing

  • I checked every changed line in a .rs file. Each is a comment (//, /// or //!), so no code changes.
  • git grep -i -E "base[ -]units?" over finance/ now finds nothing. The only lines still ending in "base" use it to mean the base asset.

Generated by Claude Code

The solana-finance plugin's rule: an amount's smallest denomination, the
raw integer a program works in, is a minor unit (cent, lamport); do not
say "base units". In finance "base" already names the first asset of a
pair, as in GOLD/USD, so "base units" read as units of the base asset.

Doc comments, code comments, READMEs and CHANGELOGs across lending,
managed fund, perpetual futures, token swap and betting market now say
"minor unit(s)", including "sub-minor-unit" and phrases split across a
line break. The order book README, where "base units" meant the BASE
token's minor units, now says "BASE minor units" and "QUOTE minor units".
"Base" where it names the base asset of a pair is unchanged. Only
comments and documentation change; no code does.

Claude-Session: https://claude.ai/code/session_01GZHin6BQpAqf7j2ucSZWkx
@mikemaccana
mikemaccana merged commit 40a0ef4 into main Nov 10, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant