Repository navigation
Say "minor units", not "base units", for the smallest token denomination - #211
Merged
Merged
Conversation
The solana-finance plugin's rule: an amount's smallest denomination, the raw integer a program works in, is a minor unit (cent, lamport); do not say "base units". In finance "base" already names the first asset of a pair, as in GOLD/USD, so "base units" read as units of the base asset. Doc comments, code comments, READMEs and CHANGELOGs across lending, managed fund, perpetual futures, token swap and betting market now say "minor unit(s)", including "sub-minor-unit" and phrases split across a line break. The order book README, where "base units" meant the BASE token's minor units, now says "BASE minor units" and "QUOTE minor units". "Base" where it names the base asset of a pair is unchanged. Only comments and documentation change; no code does. Claude-Session: https://claude.ai/code/session_01GZHin6BQpAqf7j2ucSZWkx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
"Base unit(s)" becomes "minor unit(s)" wherever it means the smallest denomination of a token. That covers doc comments, code comments, READMEs and CHANGELOGs in 53 files across lending, managed fund, perpetual futures, token swap and betting market, in every framework.
The replacement also covers:
"Base" where it names the base asset of a trading pair, as in GOLD/USD, is unchanged. That covers the order book's base/quote, the prop AMM and the managed fund.
Why
The solana-finance plugin (
skills/solana/SKILL.md) says: "a minor unit is the smallest denomination, the raw integer programs operate on - cent, penny, sen, lamport. Use these terms; do not say 'base units'." In finance, "base" already names the first asset of a pair, so "base units" reads as units of that asset.Testing
.rsfile. Each is a comment (//,///or//!), so no code changes.git grep -i -E "base[ -]units?"overfinance/now finds nothing. The only lines still ending in "base" use it to mean the base asset.Generated by Claude Code