Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After an image edit renders, Enter can run before ink-prompt's passive onChange reaches the parent. The submission then snapshots an older draft revision. Its late image notification looks like a newer user edit, so accepted text/image markers remain in the composer and a later /retry-turn appends to them.
Capture the child's submitted value synchronously before a fresh submission snapshots its revision. Keep the existing pending-send path and later-edit revision protections. The real CLI regression observes an empty composer after the accepted image turn, using the revision captured before Enter.
Evidence: the original failure reproduced on unchanged main. An identical temporary delayed-image-notification fault fails on base (expected revision 1, actual 2) and passes with the capture statement (2/2). Independent real-CLI controls accept the causal fix and preserve newer edits, same-text edits, pending drafts, rejected drafts, held-send decline/resend and bang-shell submission. All temporary fault/trace code was removed.
Validation: full provider suite 270 passed/5 skipped; real terminal image and slash-command E2E 29 passed; fake-Codex E2E 18 passed; typecheck, lint, static and exact CI quality gates pass. Independent verifier accepted the three-line file-ceiling increase and its ordering-specific rationale. This standalone PR includes the same model-picker fixture readiness correction as #261: wait for the loaded row before testing navigation, preserving every navigation/favorite assertion.