Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native OpenAI Chat requests with a token cap currently send
max_tokens, which the current model rejects. Selectmax_completion_tokensfrom the actual SDK endpoint (api.openai.com), preserve compatible endpoints and explicit dialect overrides, and retain the inferred cap when an override is undefined. No model-name guessing or reasoning-setting changes.Validation: final provider black-box suite 278 passed / 5 skipped; typecheck, build, lint (40 existing warnings), and 22 static tests passed. Eight registry/SDK/loopback regressions cover native and compatible endpoints, both explicit spellings, missing caps, and undefined options. Independent verification accepted 25 SDK cases, four real HTTP captures, and the eight regressions, including baseline failures and unchanged non-limit request fields.
This removes the native token-field rejection. The separately observed native Chat tools/reasoning incompatibility remains; this PR does not claim a successful live Chat task or infer a native upstream from an opaque localhost proxy.