Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native Responses can include provider-reported usage in
response.failedorresponse.incomplete. Term2 previously threw before forwarding that usage, leaving the paid attempt recorded asmissing_usage.Emit an accounting-only usage event before preserving the terminal error on both HTTP and WebSocket streams. The core can price the failed attempt without accepting its output or dispatching its tools. Missing, invalid, or partial input/output totals remain unknown; unary behavior is unchanged.
Validation: full provider black-box suite 273 passed / 5 skipped, typecheck, lint (40 existing warnings), 22 static checks, and all quality gates. The existing Responses file ceiling is raised from 902 to 924 with a reviewed reason: terminal usage validation remains beside normalization and the HTTP/WebSocket loops; extracting only this small guard would scatter one accounting contract. No global limits change. Three new built-CLI regressions cover failed/incomplete accounting and a successful tool-dispatch control (2.42 seconds of test time; three CLI launches). Independent verification accepted ten HTTP/WebSocket CLI checks plus six source controls covering persisted costs, cache reads/writes, missing/partial/zero usage, cancellation, no double counting, and retry guards.