Repository navigation
Revert the 500k unknown-model assumption in core - #10
Merged
Merged
Conversation
This reverts commit c69dde5. 500,000 tokens is Term2's choice for models it cannot size, so it does not belong in the shared core. The core keeps its previous value while the host-supplied assumption is designed; Term2 continues to apply its own value in the meantime. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JqbJBBoCXgqyyFZaYn5Co4
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #7 (
c69dde5).DEFAULT_ASSUMED_CONTEXT_WINDOWgoes back to 128,000 and the README paragraph describing the 500,000-token assumption is removed.500,000 tokens is Term2's choice for models it cannot size. Putting that number in the shared core makes every other host inherit one consumer's policy, so it does not belong here.
This does not change Term2's behavior today: it applies its own value through a pnpm patch over the published
0.2.0-alpha.2. Nothing was published with #7 in it; the release PR #9 is back in draft.Follow-up, not in this PR: the core still falls back to its own constant when a model has no catalogue capacity (
recovery-compaction.ts). For the host to own the number, that path should take the assumption from the host instead.Verification
On Node 24 / pnpm 11.7.0 at this commit:
pnpm build,pnpm typecheck,pnpm test(wire 13, repo 8) andnode scripts/agent-package-smoke.mjspass.pnpm smoke:checkoutwas not run locally; CI runs it.Generated by Claude Code