Repository navigation
gh-153605: Fix gettext.GNUTranslations struct.error on a malformed .mo file - #153606
Merged
StanFromIreland merged 4 commits intoOct 25, 2026
Merged
Conversation
…med .mo file GNUTranslations._parse unpacked the .mo header and seek tables without checking the file was long enough, so a truncated file or one whose seek tables point past the end leaked a struct.error instead of the OSError the module raises for other malformed input. Validate the lengths first.
|
This PR is stale because it has been open for 90 days with no activity. |
| hdr = '>4I' | ||
| else: | ||
| raise OSError(0, 'Bad magic number', filename) | ||
| if buflen < 20: |
Member
There was a problem hiding this comment.
I don't think this dance is worth it for better error messages here, I suggest we move the check above and just loose the "Bad magic number" error. They are only raised on truncated files, which are unlikely in practice.
StanFromIreland
approved these changes
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gettext.GNUTranslationsunpacked the.moheader and per-entry seek tableswith
struct.unpackwithout first checking the file was long enough, so atruncated file or one whose seek tables point past the end raised a raw
struct.errorinstead of theOSErrorthe module already raises for othermalformed input. Validate the lengths and raise
OSErrorinstead.