Repository navigation
Use Intel Homebrew paths for the x86-64 macOS ASAN builder - #817
Merged
Merged
Conversation
The only builder using MacOSAsanNoGilBuild is "x86-64 MacOS Intel ASAN NoGIL" on itamaro-macos-intel-aws, an Intel Mac where Homebrew lives in /usr/local. The class hardcoded the Apple silicon prefix (/opt/homebrew), so configure never found OpenSSL and _ssl/_hashlib were silently not built (and test_ssl skipped). Switch it to /usr/local and rename the class to MacOSIntelAsanNoGilBuild to reflect that it's Intel-only. buildersuffix is unchanged, so existing build directories are reused. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DsXQnJ34Z2R4BdnKVBCQMx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only builder using MacOSAsanNoGilBuild is "x86-64 MacOS Intel ASAN NoGIL" on itamaro-macos-intel-aws, an Intel Mac where Homebrew lives in /usr/local. The class hardcoded the Apple silicon prefix (/opt/homebrew), so configure never found OpenSSL and
_ssl/_hashlibwere silently not built (andtest_sslskipped).Switch it to
/usr/localand rename the class toMacOSIntelAsanNoGilBuildto reflect that it's Intel-only.AI-assisted by Claude Fable 5.1