Repository navigation
Conversation
Fixes python-humanize#459 Below-base values used int(bytes_), so naturalsize(1.5) returned '1 Bytes' while larger units kept the fraction. Format non-integers with the format string (1.5 Bytes / 1.5B); keep integer behavior ('300 Bytes', '1 Byte') unchanged. Co-authored-by: CommandCodeBot <noreply@commandcode.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #459
naturalsize(1.5)returned'1 Bytes'— below the base the value was truncated withint(), while from 1 kB upwards the fraction was kept viaformat. The singular check also compared the untruncated value with 1, so1.5showed as "1 Bytes".Fix: format non-integer values below the base with the caller's
formatstring —1.5 Bytes(decimal),1.5Bwithgnu=True— keeping integer behavior unchanged (300 Bytes,1 Byte). The singular"1 Byte"branch now requires an actual integer value.Updated/added cases in
tests/test_filesize.py.tests/test_filesize.py+tests/test_number.py— 321 passed locally.Co-authored-by: CommandCodeBot noreply@commandcode.ai