Repository navigation
Fix bson preconf skipping TypedDict, Counter and defaultdict hooks - #837
Open
ShahabAhmed01 wants to merge 1 commit into
Open
ShahabAhmed01 wants to merge 1 commit into
ShahabAhmed01 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the bson preconfigured converter structuring
TypedDicts,Countersand
defaultdicts as plain dictionaries, skipping their specific structurehooks.
Root cause
BsonConverter.is_bson_mappingwas registered as a structure hook factoryfor
is_mapping. Because it was consulted before the TypedDict/Counter/defaultdict-specific factories, those types fell through to the bson
mapping factory and were structured as plain dicts, skipping their hooks.
Fix
is_bson_mappingnow excludesis_typeddict,is_counterandis_defaultdict, so those types keep their specific hooks; generic mappingand bytes-key handling are unchanged.
Tests
Adds regression tests
test_bson_typeddict,test_bson_counter,test_bson_defaultdict.Red/green
All three tests fail without the
src/cattrs/preconf/bson.pychange andpass with it. Before, bson output diverged from json and did not raise
ClassValidationErrorfor invalid TypedDict/Counter/defaultdict input;after it matches json and raises
ClassValidationError.Verification
tests/test_preconf.py— 64 passed, 22 skipped (CPython 3.14)immutables)Fixes #836