Repository navigation
ci: run unit tests and typecheck before proxy integration - #87
Merged
Merged
Conversation
The integration job is the only test check, and it does not run on pushes to main. Add a secret-free CI workflow for npm run test:unit and npm run test:types. TypeScript 7 removed baseUrl, which made the existing typecheck script fail. Drop that option so the types job can pass. Co-authored-by: ProxyMesh AI <proxymeshai@users.noreply.github.com>
Drop the separate workflow. Unit tests already run after install; add the typecheck step beside them, before the PROXY_URL check. Co-authored-by: ProxyMesh AI <proxymeshai@users.noreply.github.com>
cursor
Bot
changed the title
proxymeshai
marked this pull request as ready for review
November 2, 2026 22:23
proxymesh
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unit tests and the typecheck run inside the existing
integrationjob, immediately afternpm ciand before thePROXY_URLcheck. No new workflow.npm run test:unitwas already that step. This addsnpm run test:typesnext to it, so both finish before any proxy secret is required. The separate CI workflow from the first draft is removed.tsconfig.jsondropsbaseUrl. TypeScript 7.0.2 removed that option, sonpm run test:typesfailed on current main.pathsstill typecheck.Test plan
npm run test:unit— 23 passed, 0 failed (includes the undici tunnel and got proxy-bypass cases)npm run test:types— passes after removingbaseUrlactionlinton the integration workflowintegrationcheck on this PR: unit tests (23 passed) and typecheck succeeded before the live proxy tests, which also passed