Repository navigation
Reject Enum labels that collide with prefixed metric names - #1226
Open
zhechen-cs wants to merge 1 commit into
Open
zhechen-cs wants to merge 1 commit into
zhechen-cs wants to merge 1 commit into
Conversation
Signed-off-by: Zhe Chen <zhechen.cs@connect.hku.hk>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An
Enumuses its full metric name as the state label, but the overlap check only checks the unprefixed name. For example,Enum('state', ..., namespace='app', labelnames=['app_state'], states=['running', 'stopped'])accepts the conflicting label and silently overwrites its values. Two children then expose duplicate time series with conflicting values.Check the fully constructed name before registration, retaining the existing unprefixed-name check. Added regressions for namespace, subsystem, and their combination, including registry reuse after failure and valid labeled children. All three collision cases fail on the unmodified base.
Validation on macOS / Python 3.12:
tox -e flake8,isort,mypyandgit diff --check: passed.Local HTTP tests used
NO_PROXY=localhost,127.0.0.1,::1to bypass the local proxy.@csmarchbanks