Repository navigation
Avoid retaining nameless collectors after repeated registration - #1224
Open
zhechen-cs wants to merge 1 commit into
Open
zhechen-cs wants to merge 1 commit into
zhechen-cs wants to merge 1 commit into
Conversation
Signed-off-by: Zhe Chen <zhechen.cs@connect.hku.hk>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
support_collectors_without_names=True, registering the same collector twice adds two entries to_collectors_without_names, while the main registry stores it only once. Afterunregister(), normal collection is empty butrestricted_registry()still calls the collector and exposes its stale metrics.Keep the auxiliary list unique on registration. The regression covers repeated registration, normal and restricted collection, unregistering, and registering the collector again. This covers a remaining case after #1191, which fixed unregistering a collector registered once.
Validation: the regression fails on the unmodified base. After the fix, 429 tests pass and 14 are skipped; the configured flake8, isort and mypy checks pass. Local HTTP tests used
NO_PROXY=localhost,127.0.0.1,::1to bypass the local proxy.@csmarchbanks