Repository navigation
Reject duplicate label names before metric registration - #1217
Merged
Merged
Conversation
Signed-off-by: fhgffy <102001626+fhgffy@users.noreply.github.com>
| raise ValueError('Reserved label methe fric name: ' + l) | ||
| # 2026-10-09: Duplicate names collapse distinct label sets during collection. | ||
| if len(labelnames) != len(set(labelnames)): | ||
| raise ValueError('Duplicate label names') |
Member
There was a problem hiding this comment.
Can we have the error message include which labelnames have duplicates to help with debugging?
Author
There was a problem hiding this comment.
Removed the date prefixes and added the duplicate label names to the error message. Local tests passed.
Remove date prefixes and include each duplicated label name in the validation error. Cover multiple duplicates, repeated names and Unicode labels. Signed-off-by: fhgffy <102001626+fhgffy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Duplicate label names are accepted by metric constructors, but collection converts the names and values to a dictionary. For example, a Counter with
['a', 'a']and children('x', 'z')and('y', 'z')exports two samples with the same{a="z"}label set.Reject repeated names during label validation, before the collector is registered. This applies to Counter, Gauge, Summary, Histogram, Info and Enum. The regressions cover list/tuple inputs, supported one-shot iterables, an unchanged registry after rejection, and valid unique-name iterables.
Validation on Python 3.14:
git diff --check, and wheel build pass.@csmarchbanks