Skip to content

gh-prs-merge: name a check GitHub never started, not 'test=fail' (0.68.4) - #193

Merged
ralyodio merged 1 commit into
masterfrom
prs-merge-billing-reason
Oct 19, 2026
Merged

ralyodio merged 1 commit into
masterfrom
prs-merge-billing-reason

Conversation

@ralyodio

Copy link
Copy Markdown
Contributor

Today's sweep printed checks not green: test=fail for cigarunderground.org#12 and mediaanalyzer.pro#16. Neither test ran: GitHub refused both jobs ("The job was not started because recent account payments have failed…"), which only shows in the check run's annotation.

  • gh pr checks now asks for link; Check.link carries the job URL.
  • New Gh.refusedToStart() reads check-runs/<job>/annotations for red Actions checks and returns the ones GitHub never started.
  • The skip reason becomes checks not green: test=fail — GitHub never started test, so nothing was tested: "The job was not started because…" (account billing, not the code; run the gate locally and merge by hand).
  • Only called when a check is red, so a green sweep makes no extra calls. A real failure keeps its plain reason (tested).

Verified live: against mediaanalyzer.pro#16 it returns {names:["test"], message:"The job was not started because recent account payments have failed…"}.
Tests: test/prs-merge.test.ts 55/55, tsc --noEmit clean. Full suite: 2 unrelated failures (dev2-deploy-app 80s timeout under load, proxy env coverage), not touched here.

🤖 Generated with Claude Code

…t a failure

A billing block or account lock fails every Actions job in seconds with no
runner and no log. gh pr checks reports that as test=fail, so the sweep
printed 'checks not green: test=fail' and sent the reader off to debug a test
that never ran. The truth is only in the check run's annotation.

Red checks now carry their job link; for each, the sweep reads the check-run
annotations and, when GitHub says 'The job was not started because ...',
appends that sentence to the skip reason and says it is billing, not code.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

ThreatCrush Security Scan

33 finding(s)

HIGH/CRITICAL: 7 | MEDIUM: 12 | LOW: 14

Severity Rule Location
HIGH py-ssrf-outbound-request dev2/dev2-site:151
HIGH py-ssrf-outbound-request dev2/dev2-site:1060
HIGH py-ssrf-outbound-request dev2/dev2-site:1775
HIGH sh-remote-script-execution root-ubuntu.sh:3250
HIGH sh-remote-script-execution root-ubuntu.sh:3251
HIGH sh-remote-script-execution root-ubuntu.sh:5146
HIGH sh-remote-script-execution root-ubuntu.sh:5150
MEDIUM sql-template-interpolation dev2/dev2-site:1286
MEDIUM sql-template-interpolation dev2/dev2-site:1363
MEDIUM sh-remote-script-execution root-ubuntu.sh:5354
MEDIUM redos-nested-quantifier src/domain-free.ts:56
MEDIUM redos-nested-quantifier src/emoji.ts:167
MEDIUM redos-nested-quantifier src/icon.ts:166
MEDIUM redos-nested-quantifier src/mail.ts:1047
MEDIUM sql-template-interpolation src/users-dump.ts:487
MEDIUM sql-string-concatenation src/users-dump.ts:507
MEDIUM sql-template-interpolation src/users-dump.ts:540
MEDIUM sql-string-concatenation src/users-dump.ts:574
MEDIUM redos-nested-quantifier src/wcag.ts:556
LOW secret-generic-credential src/credentials.ts:36
LOW secret-generic-credential src/credentials.ts:53
LOW secret-generic-credential src/credentials.ts:56
LOW secret-generic-credential src/credentials.ts:61
LOW secret-generic-credential src/user-export.ts:689
LOW secret-generic-credential src/user-export.ts:695
LOW secret-generic-api-key test/credentials.test.ts:208
LOW secret-generic-credential test/mail.test.ts:141
LOW secret-generic-credential test/proxy.test.ts:69
LOW secret-generic-credential test/proxy.test.ts:85
LOW secret-generic-credential test/shorten.test.ts:36
LOW secret-database-url test/users-dump.test.ts:108
LOW secret-database-url test/users-dump.test.ts:119
LOW secret-database-url test/users-dump.test.ts:120

Snippets are redacted; ThreatCrush never prints matched credential material.

@ralyodio
ralyodio merged commit 6bfc614 into master Oct 19, 2026
5 checks passed
@ralyodio
ralyodio deleted the prs-merge-billing-reason branch October 19, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant