Repository navigation
Release: build Windows again, push the version bump, survive Cloudflare - #78
Merged
Merged
Conversation
Windows: since #46 the release build failed. liquid_glass_renderer's shaders cannot be compiled for Skia; Flutter then compiles them without Skia and goes on, but prints the Skia compiler's "error: 58: ..." lines as a warning, and MSBuild fails the step on any line of that shape although the tool exited 0. flutter_assemble now runs through windows/flutter/tool_backend.ps1, which rewords "error" inside that warning only and keeps the tool's exit code. The glass never runs on desktop. A Windows build now runs in CI on changes that can break it. Version: the bump was pushed with the RELEASE_PAT secret, which GitHub now refuses (403), so 3.2.1+9 was never written back. It is pushed with GITHUB_TOKEN, and pubspec.yaml is set to 3.2.1+9, the version that shipped. Admin: Cloudflare answers GitHub's runners with a challenge page, so the CDN upload failed with a 403. That is now a warning, and the backend takes a published release from GitHub itself (sozo-backend). The release carries Sozo-v<version>-release.json with the build number for it. platforms: windows rebuilds only Windows into an existing release, and keeps the checksums of the files it did not rebuild.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v3.2.1 run (43586788143) broke in three places:
Windows. Broken since #46 added
liquid_glass_renderer; v3.2.1 is the second release without Windows.error: 58: loop index ...) as a warning.flutter_assemblewith code -1 even though the tool exited 0.flutter_assemblenow runs throughwindows/flutter/tool_backend.ps1. It rewords "error" inside that warning only and keeps the tool's exit code, so a shader that really fails still fails the build. The glass never runs on desktop anyway (usesFlutterGlass).windows-ci.ymlbuilds Windows on changes that can break it (pubspec,windows/, this workflow). This PR runs it, which is the proof the fix works.Version push.
RELEASE_PATsecret, which GitHub now refuses ("Permission to professorDeveloper/sozo.git denied", 403).GITHUB_TOKEN; the ruleset does not require a PR.pubspec.yamlis set to3.2.1+9, the version that shipped. Without it, the next release would start from 3.2.0+8.Admin panel.
deferredwith a warning instead of failing the run. Real errors still fail it.Sozo-v<version>-release.json(version, build, sha, notes). The backend uses it to take a published release from GitHub by itself: it uploads the APKs to R2, adds the download rows and updates the in-app updater (sozo-backend PR).platforms: windows. Rebuilds only Windows into an existing release. The SHA256SUMS of the files it did not rebuild are kept, by merging with the published list.After merging: run Release → Telegram with
bump: none,platforms: windows,release: draft,announce: off. That adds Windows to the v3.2.1 draft without rebuilding macOS.