Repository navigation
Sources: show a renamed source under its current name - #76
Merged
Merged
Conversation
Two places showed the name a source had when something was saved, not the one it has now: the "TMDB › <source>" mark on a catalogue title opened before, and the source line on a download. VidAPI is now VixSrc on the server (same id), and both kept saying VidAPI with VidAPI's icon. The installed source's name and icon win when it is still installed; the saved ones are kept for a source that is gone, or a list that does not arrive within two seconds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goes with professorDeveloper/sozo-backend
rename-vidapi-vixsrc(VidAPI → VixSrc, same idvidapi).The backend rename reaches every screen that reads the live provider list, 3.2.0 included. Two places show a name saved earlier instead, and kept saying VidAPI with VidAPI's icon:
CatalogueLinkstores name + icon in Hive with no expiry.locate()now refreshes a remembered link from the installed list (2 s cap); a source that is gone keeps the saved name.downloadSourceName), saved name second, bare id last.The source picker and relink sheet already read the live list.
Tests:
test/features/download/download_source_name_test.dart(new), two cases incatalogue_resolver_test.dart.flutter test test/features/download test/features/detail test/features/mobile_ux_test.dart: 793 passed.flutter analyzeon the changed files: clean.On 3.2.0 these two places keep "VidAPI" for links and downloads saved before the rename; this is the fix for 3.2.1.