Repository navigation
Fix NATS connection error showing port None when URL has no port - #33
Open
karanthashika wants to merge 1 commit into
Open
karanthashika wants to merge 1 commit into
karanthashika wants to merge 1 commit into
Conversation
karanthashika
requested review from
guptadevik2003,
iamDyeus and
sujal-maheshwari2004
as code owners
November 16, 2026 17:43
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #25
What changed
:Nonefor the port when no explicit port was provided in the connection URL.priompt_sdk/client.pyto use{u.port or 4222}so it falls back cleanly to the standard NATS port (4222) if omitted.How I tested it
test_subscribe_nats_default_portintests/test_client.pycovering default port fallback, explicit port preservation, and token secrecy.pytest -qand verified all 29 tests passed successfully.