Skip to content

Preserve IPv6 authorities and decode connection URL tokens - #29

Closed
ShahadatTest wants to merge 1 commit into
priompt:mainfrom
ShahadatTest:fix/connection-url-authority
Closed

ShahadatTest wants to merge 1 commit into
priompt:mainfrom
ShahadatTest:fix/connection-url-authority

Conversation

@ShahadatTest

Copy link
Copy Markdown

Preserve the URL authority after userinfo so IPv6 brackets, hostname spelling and explicit ports reach gRPC unchanged. Percent-decode the username token without treating a literal plus as a space. Keep urlparse's existing port validation.

Validation: the new IPv6, mixed-case authority and encoded-token regressions fail on upstream. All 39 offline tests pass on Python 3.13.18, covering bare hosts, no-port URLs, literal plus, port zero and invalid ports. No server, actual token or external RPC is used.

Closes #20

AI assistance: OpenAI Codex implemented, inspected and tested this change. No independent human review is claimed.

@sujal-maheshwari2004

Copy link
Copy Markdown
Member

Hi @ShahadatTest, thank you for taking the time to send this. We're closing it, and it's not about the quality of the change.

The issue it fixes is labelled good first issue. In this organisation those are reserved for people making their first open-source contributions: we're onboarding a group of students who will learn the workflow on exactly these issues. We've now written this down in our contribution guide.

If you'd like to keep contributing, we'd welcome help on our help wanted issues. That's where experienced and AI-assisted effort makes a real difference. Please claim one by commenting, wait to be assigned before opening a pull request, and keep to at most two open pull requests at a time.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keep IPv6 brackets and percent-decode the token when parsing priompt:// URLs

2 participants