Repository navigation
Preserve IPv6 authorities and decode connection URL tokens - #29
Closed
ShahadatTest wants to merge 1 commit into
Closed
ShahadatTest wants to merge 1 commit into
ShahadatTest wants to merge 1 commit into
Conversation
Member
|
Hi @ShahadatTest, thank you for taking the time to send this. We're closing it, and it's not about the quality of the change. The issue it fixes is labelled If you'd like to keep contributing, we'd welcome help on our Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve the URL authority after userinfo so IPv6 brackets, hostname spelling and explicit ports reach gRPC unchanged. Percent-decode the username token without treating a literal plus as a space. Keep urlparse's existing port validation.
Validation: the new IPv6, mixed-case authority and encoded-token regressions fail on upstream. All 39 offline tests pass on Python 3.13.18, covering bare hosts, no-port URLs, literal plus, port zero and invalid ports. No server, actual token or external RPC is used.
Closes #20
AI assistance: OpenAI Codex implemented, inspected and tested this change. No independent human review is claimed.