Repository navigation
fix: derive slots with validate.Slots so {{ and }} are literal braces - #35
Merged
Merged
Conversation
proto v0.7.3 lets templates write literal braces as {{ and }}, exactly as in
Python's str.format. deriveSlots used its own \{(\w+)\} regexp, which reads
"{{name}}" as slot "name"; validate then rejected the publish with
"declared slots never used". Require proto v0.7.3 and derive slots with
validate.Slots, the same rules the server validates against.
sujal-maheshwari2004
requested review from
guptadevik2003 and
iamDyeus
as code owners
November 15, 2026 05:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to priompt/proto#19, released in proto v0.7.3.
Templates may now contain literal braces written
{{and}}, exactly as in Python'sstr.format.deriveSlotsused its own\{(\w+)\}regexp, which reads{{name}}as slotname, so validation would reject the publish withdeclared slots never used.Change
github.com/priompt/proto v0.7.3.deriveSlotscallsvalidate.Slots, the same rules the server validates against.Tested
TestDeriveSlotsadds a case:Answer {question}. Reply as JSON: {{"answer": "{{name}}"}}gives[question].promptctl publishof that JSON-example prompt printspublished priompt://acme/json (536901c63ad8), the same hash aspriompt put.go vet ./...andgo test ./...pass.