Repository navigation
Allow sorting patches by committer - #123
Merged
JelteF merged 3 commits intoOct 18, 2026
Merged
Conversation
On the page of a commitfest, the Committer column header can now be clicked to sort the patch list by committer, just like the other sortable columns. Combined with the Committed status filter, this makes it easy to see who committed what in a commitfest. Committers are sorted by last name, then first name and username, which is the same order that the Committer model uses. Patches without a committer are always shown last, and the patch ID is used as a tiebreaker. Like with the other sort orders, open patches are still shown before closed ones. The dashboard is left unchanged, since this was only requested for the commitfest page. Fixes postgres#112
JelteF
reviewed
Oct 18, 2026
| @@ -0,0 +1,189 @@ | |||
| from django.contrib.auth.models import User | |||
Collaborator
There was a problem hiding this comment.
Let's remove this test. I think a generic sorting test could be useful for coverage. But this is way to specialised on this specific sorting method. Generic sorting test should be a separate PR.
JelteF
approved these changes
Oct 18, 2026
The tests were very specialised to this one sort method. A generic test covering all sort keys would be more useful and belongs in a separate PR.
Descending kept patches without a committer at the bottom and kept the `p.id` tiebreaker ascending, so clicking the header again didn't reverse the list. Now it does. Since PostgreSQL already sorts NULLs last when ascending and first when descending, the explicit `NULLS LAST` clauses are no longer needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #112
The Committer column on the commitfest page can now be clicked to sort by committer, like the other columns. Combined with the Committed status filter this makes it easy to see who committed what in a commitfest.