Skip to content

feat!: require Python 3.11 for the CLI - #972

Open
tdstein wants to merge 5 commits into
mainfrom
symphony/posit-dev_rsconnect-python_948-9116b2e5d0742e53
Open

tdstein wants to merge 5 commits into
mainfrom
symphony/posit-dev_rsconnect-python_948-9116b2e5d0742e53

Conversation

@tdstein

@tdstein tdstein commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

- CLI Python: 3.8+
+ CLI Python: 3.11+
  Content Python: 3.8+ (tested separately)

Remove obsolete compatibility dependencies and branches, regenerate the lockfile, and update CI and release guidance. The inspector continues to run under the CLI Python. The development version moves to 1.34.0.dev1, so the change ships in a minor release, per ADR-0001.

Evidence

  • Python 3.11 and 3.15: 524 focused tests passed on each.
  • Content Python 3.8–3.15: all eight manifest and TOML inspection cases passed without skips.
  • just lint and uv lock --locked passed; Pyright is advisory and reports existing type errors.
  • The full suite encountered sandbox cache restrictions; with a writable uv cache, 83 quickstart tests passed, while the Quarto smoke test could not open its macOS cache database.

Merge Danger

Door: Two-way

Blast Radius: CLI users on Python 3.8–3.10 remain on 1.33.2. Do not merge until 1.33.2 is released.

Closes #948

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
PR Preview Action v1.8.2

QR code for preview link

🚀 View preview at
https://posit-dev.github.io/rsconnect-python/pr-preview/pr-972/

Built to branch gh-pages at 2026-11-13 19:36 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11214 9934 89% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
rsconnect/actions.py 62% 🟢
rsconnect/actions_content.py 67% 🟢
rsconnect/api.py 90% 🟢
rsconnect/bundle.py 90% 🟢
rsconnect/environment.py 94% 🟢
rsconnect/log.py 75% 🟢
rsconnect/main.py 89% 🟢
rsconnect/metadata.py 92% 🟢
rsconnect/models.py 93% 🟢
rsconnect/preflight.py 87% 🟢
rsconnect/pyproject.py 100% 🟢
rsconnect/quickstart/quickstart.py 97% 🟢
rsconnect/subprocesses/inspect_environment.py 73% 🟢
TOTAL 85% 🟢

updated for commit: 4fd4022 by action🐍

Bump the development version to 1.34.0.dev1 so dropping Python 3.8–3.10
ships in a minor release, per ADR-0001.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@tdstein tdstein changed the title Require Python 3.11 for the CLI feat!: require Python 3.11 for the CLI Nov 12, 2026
@tdstein tdstein self-assigned this Nov 12, 2026

@joshyam-k joshyam-k left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very satisfying diff! I had no idea how many if/else and trys we had across the codebase to keep support for 3.8-3.10 propped up lol

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Require Python 3.11+ for the CLI Python

2 participants