Repository navigation
Use the configured logger for pages and locators - #83
Merged
Merged
Conversation
gimler
commented
Mar 5, 2026
gimler
force-pushed
the
feature/logger
branch
2 times, most recently
from
March 5, 2026 09:07
b0cda81 to
20216ca
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
stloyd
reviewed
Mar 7, 2026
| private readonly string $pageId, | ||
| private readonly PlaywrightConfig $config, | ||
| private readonly LoggerInterface $logger = new NullLogger(), | ||
| ?LoggerInterface $logger = null, |
Collaborator
There was a problem hiding this comment.
I would remove it from here and use only the one from config, and in confing spawn the null one by default.
smnandre
reviewed
Jun 2, 2026
smnandre
reviewed
Jun 2, 2026
smnandre
approved these changes
Nov 7, 2026
smnandre
force-pushed
the
feature/logger
branch
from
November 7, 2026 19:32
d4c8a05 to
9297bac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
PlaywrightConfig::loggerfor page and locator diagnostics, including locators inside frames. Log native locator failures and redact sensitive values from navigation URLs and error details.