[aik099]

Allow PHP callers to launch browsers such as Brave or a locally built Chromium by setting withExecutablePath() or PW_EXECUTABLE_PATH. An explicit builder setting takes precedence over configuration.

Builds on #101 by @feder-cr.

[aik099]

The 4 integration failures (RouteTest::testCanRedirectNavigationRequest*) aren't from this change: they fail on main too with Playwright 1.64, as in the Nightly runs since Oct 8. #186 fixes them.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[kbond]

Rebased onto main and kept the feature’s changelog entry under Unreleased. The configuration now preserves a path named 0 instead of treating it as unset.

I verified that Chromium launches from PW_EXECUTABLE_PATH even when the path contains spaces, and that an explicit withExecutablePath() setting overrides the configured path.

[aik099]

Thank you for the review.

Is the 0 executable path have a special meaning to be considered as a valid path?

[kbond]

@aik099 No special meaning. 0 is a valid filename, but PHP treats the string "0" as false. I changed the check so only null and an empty string count as unset.

[smnandre]

(sorry i failed the rebase with that new UI and merged main ... fixed and rebased, i'm merging after)

[smnandre]

Thank you @aik099! Nice one, and sorry for the delay we've been very busy lately

(and @kbond obviously ❤️)