Repository navigation
Show each post's attachments on the print-all page - #11
Merged
Merged
Conversation
The attachment list read loops.attachment, which never holds a post's attachments, so it printed an empty heading. It was then removed (#10); this puts it back, reading postrow.attachment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shows each post's attachments on the Print all page and bumps the version to 1.0.5.
loops.attachment, which never holds a post's attachments, so it printed only an empty Attachments: heading. Remove the attachment list from the print-all page #10 removed the list; this puts it back, readingpostrow.attachment, so each post's attachments appear under it.composer.json(1.0.4 is already released). No release is made here.Claude ran the printallposts feature check in phpbbmodders/phpbb-release-tools (
feature_checks.py, updated to expect the attachment) on a test board: 4/4 pass with this change, and "the print page shows the post's attachment" fails onmaster.smoke_test.pyis clean.Investigated and written by Claude on behalf of William Jacoby (bonelifer).