Repository navigation
entityresolver: resolve Windows absolute paths - #58
Merged
Merged
Conversation
SYSTEM references in doc-base's doctype.dtd are absolute, which on Windows means C:/... . Only paths starting with / were treated as absolute, so these were appended to the including file's directory and entities like &reference.pdo.entities.pdostatement; were reported as not defined, hiding all other violations in the file. Treat drive-letter and UNC paths as absolute too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
Thank you for this. This tool hasn't been tested on Windows yet, but I am happy to support it. Main now also has windows included in the CI pipeline. |
vrana
force-pushed
the
windows-absolute-paths
branch
from
October 23, 2026 08:44
b4c5c89 to
21e004b
Compare
Contributor
Author
|
It fails on main: #59 |
Member
|
The tests will still fail after this change. If you wish to do a follow-up PR you are very welcome to do. If not I will get to it in the upcoming days when I get my hands on Windows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SYSTEM references in doc-base's doctype.dtd are absolute, which on Windows means C:/... . Only paths starting with / were treated as absolute, so these were appended to the including file's directory and entities like &reference.pdo.entities.pdostatement; were reported as not defined, hiding all other violations in the file.
Treat drive-letter and UNC paths as absolute too.