Repository navigation
Conversation
jrraymond
marked this pull request as ready for review
November 8, 2026 19:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI fails on current Rust because existing closures contain unnecessary parentheses and an iterator conversion is redundant. Rust 1.56 jobs resolve test dependencies that require newer compilers, and the macOS 14 ARM runner is no longer supported.
Remove the lint failures, including redundant lifetimes in the serde implementation, move ARM jobs to macOS 15 and keep ABI-required NEON enabled, and use a dedicated compatible lockfile with
--lockedfor MSRV jobs. The published dependency requirements remain unchanged. Replace the unset$FEATURESargument with--all-featuresand lint serde support as well.Local validation includes formatting, all-features library Clippy, debug/release tests with serde, no-default-features tests, Rust 1.56 tests using the pinned dependencies, and wasm32/wasm64 compilation with SIMD. The hosted CI matrix validates the remaining platforms and browser tests.