Repository navigation
Fix grow_and_insert overflow regression test abort - #147
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing
usize::MAXtogrow_and_insertcurrently attempts an allocation of roughly 2 exabytes and aborts the regression test process. Use checked addition to reject the unrepresentable length before allocating or reaching the unchecked write.Update the regression test to expect the explicit capacity-overflow panic in debug and release builds, and document the panic condition.
Validation:
cargo test --all-featurescargo test --release --all-featurescargo test --no-default-features --tests --libcargo fmt --all --checkcargo clippy -- -D warningsAn additional
cargo clippy --all-features -- -D warningscheck reports pre-existing redundant static lifetime warnings insrc/serde_impl.rs.