Repository navigation
Fix the wasm64 build when SIMD is enabled - #146
Merged
Merged
Conversation
The SIMD code uses 32-bit wasm instructions, so a 64-bit wasm (wasm64) build with SIMD turned on failed to compile. wasm64 now uses the plain code path. CI checks wasm64 with and without SIMD.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SIMD code uses 32-bit wasm instructions, so a 64-bit wasm (wasm64)
build with SIMD turned on failed to compile. wasm64 now uses the plain
code path. CI checks wasm64 with and without SIMD.
Testing
wasm64 is a tier 3 target, so checking it needs nightly and a standard library built from source:
rustup toolchain install nightly --component rust-src RUSTFLAGS="-C target-feature=+simd128" cargo +nightly check -Zbuild-std=std,panic_abort --target wasm64-unknown-unknownBefore this change, this fails with "unresolved import core::arch::wasm32"; after it, it builds. wasm32 behaves exactly as before.