Skip to content

Show Google profile pictures - #155

Merged
arnestrickmann merged 1 commit into
mainfrom
arnestrickmann/google-profile-pictures
Oct 26, 2026
Merged

arnestrickmann merged 1 commit into
mainfrom
arnestrickmann/google-profile-pictures

Conversation

@arnestrickmann

@arnestrickmann arnestrickmann commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • show Google profile photos for workspace members and the signed-in Account entry
  • fall back safely to initials when no photo is available or an image fails
  • refresh stored Google name and photo claims on subsequent Google sign-ins
  • preserve expanded and collapsed sidebar alignment, lazy-load photos, and suppress referrer data
  • add component, sidebar, members-page, and Google callback regression coverage

Test Coverage

All new code paths have regression coverage: image rendering, missing and failed image fallback, blank and Unicode names, Account navigation and sizing, Members wiring, repeat sign-in profile refresh, and refresh failure handling.

Pre-Landing Review

Two independent review passes and a structured review gate completed. Findings around member-column alignment, collapsed and expanded sidebar alignment, eager image loading, stale Google profile claims, dead code, and missing integration tests were fixed. No P1 findings remain.

Design Review

Two alignment issues were found and fixed: Members header spacing now matches the avatar column, and the Account photo sits in the standard icon slot in both sidebar states.

Eval Results

No prompt-related files changed, so evals were skipped.

Scope Drift

Scope Check: CLEAN

Plan Completion

No plan file detected.

Verification Results

  • full repository test suite passed, including 241 web tests
  • all package typechecks passed
  • lint passed, with one pre-existing Fast Refresh warning outside this diff
  • web app, docs, and website production builds passed
  • all changed files pass Prettier and git diff checks

Test plan

  • bun run test
  • bun run typecheck
  • bun run lint
  • bun run build
  • targeted Google callback and avatar integration tests after final formatting

Documentation

All project documentation was audited against the diff. No updates were needed.

@arnestrickmann

Copy link
Copy Markdown
Contributor Author

@greptile

@arnestrickmann

Copy link
Copy Markdown
Contributor Author

@greptileai

@arnestrickmann
arnestrickmann merged commit 1119bd3 into main Oct 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant