Repository navigation
Show Google profile pictures - #155
Merged
Merged
Conversation
Contributor
Author
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Coverage
All new code paths have regression coverage: image rendering, missing and failed image fallback, blank and Unicode names, Account navigation and sizing, Members wiring, repeat sign-in profile refresh, and refresh failure handling.
Pre-Landing Review
Two independent review passes and a structured review gate completed. Findings around member-column alignment, collapsed and expanded sidebar alignment, eager image loading, stale Google profile claims, dead code, and missing integration tests were fixed. No P1 findings remain.
Design Review
Two alignment issues were found and fixed: Members header spacing now matches the avatar column, and the Account photo sits in the standard icon slot in both sidebar states.
Eval Results
No prompt-related files changed, so evals were skipped.
Scope Drift
Scope Check: CLEAN
Plan Completion
No plan file detected.
Verification Results
Test plan
Documentation
All project documentation was audited against the diff. No updates were needed.