Repository navigation
ask google for who is free, other contacts and tasks, and drop the scopes nothing uses - #154
Merged
Merged
Conversation
…opes nothing uses Google's restricted-scope review turns down any scope the app doesn't visibly use, so the sign-in stops asking for documents, spreadsheets and presentations: the Docs and Slides APIs were never called, and Sheets goes through drive, which covers all three. In their place come three sensitive scopes, each with the actions that use it: - calendar.events.freebusy: See when people are free, the availability collection's Check, which asks Google's free/busy of the account and the people named and answers each one's busy times and the times all of them are free, on the primary calendar's clock. Someone whose calendar can't be seen is said to be so, never free. - contacts.other.readonly: Read other contacts, the people Gmail keeps under Other contacts, listed, searched and opened, with Save to contacts (under Add and edit contacts) copying one into Google Contacts. - tasks: Read tasks and Add and edit tasks, Google Tasks as a tree of lists and their tasks, narrowed to those to do or done; tasks are made, edited, moved to another list by its name, completed and reopened, and never deleted. The time parsing and time zone arithmetic the events collection had move to calendar-time.ts, which the availability check shares. The docs, the privacy policy (which names Google Tasks, free or busy times and other contacts), the env help and the seed follow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prep for Google's restricted-scope verification. Google turns down any scope the app doesn't visibly use, and every scope has to appear in the demo video. So this PR settles the scope list before we submit.
Removed:
documents,spreadsheetsandpresentations. The Docs and Slides APIs were never called, and Sheets requests already go throughdrive, which those three APIs also accept.Added, each a sensitive scope with the actions that use it:
calendar.events.freebusyavailability_checkcontacts.other.readonlyother_contacts_list,_get,_save(saving needs Add and edit contacts)taskstasks_list,_get,_create,_update,_complete,_reopengoogle-events.tsmoved tocalendar-time.ts, so the availability check uses the same code..env.exampleand the seed.Existing connections keep working. Their new actions show as "Not allowed at sign-in" until the person signs in to Google again.
Before deploying, in the Cloud project:
calendar.events.freebusy,contacts.other.readonlyandtasks, and removedocuments,spreadsheetsandpresentations.Testing: new unit tests for all three connectors. Typecheck, lint and every package's tests pass, and the docs and website build. These features haven't been run against a live Google account yet.
Open workspace in Conductor