Repository navigation
refactor(templates): clean up the shipped automerge and approve-fork-ci workflows - #96
Merged
Merged
Conversation
The run listing's filter and the paging stop each parsed a run's creation time and compared it with the cutoff; one jq definition now does both. A test case makes the listing filter bite on its own: an older run is passed over and waited past, not only refused by the check before approval.
KM_AUTOMERGE_APP=1 and a merge was written out for act's environment, its token step and the merge script. decide now outputs it as app, and act reads that output in all three places (an environment cannot read a step's or the job's env). The gate tests evaluate the output's expression on the same three cases.
act holds the write token and runs no km, so it repeats the latest-review rule in jq and the comment marker. A table of review lists (a null user, a later comment, a dismissal, two pages) runs through both rules and must give the same answer, and act's marker must be km's MARKER.
…st in the header automerge's header no longer repeats the merge conditions: it points at km's README and src/km/automerge.py at the pinned commit. Both App workflows use secrets named CI_APP_CLIENT_ID and CI_APP_PRIVATE_KEY for two different Apps in two environments; the names stay, since brains hold them. A README section now sets up both Apps side by side, and each header names the other App and points at it, while keeping the steps for its own App so a brain's copy describes itself at the km it pins.
…ted-pins hashes in SHIPPED
Owner
Author
|
Sandbox e2e on 9c2a76c (E01, E02, E05, E05-ctl, E06, E07-github, E07-scripts, E20, AM-*, with the merge App): 16 pass, 2 fail. Both failures are jobs GitHub did not start: their annotation says the sandbox account's Actions spending limit was reached. They are not runs that failed.
|
The 1.21.0 release bump replaced the version in this requirement sentence too; the workflow's gate stays at 1.20.0.
The pin step's need= is the one place the required km is stated; the header, the README paragraph and km upgrade's note must name that version, so a release's blanket version bump that moves one of them fails a test. The release test reads only pin lines (pasrom/km, frozen:), so it neither caught nor needed to ignore the README sentence.
Owner
Author
|
Two new commits:
The release test reads only lines that contain |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup of the shipped team workflows. Behaviour is unchanged: the templates need no new
km automergeflag or output, so they still run against a pinned km 1.20.0 or later.Changes
if, the merge script'sAPP). It is now onedecideoutput,app, and act reads it in all three places. Anenvironment:key cannot readenvorsteps, so a job output is the only shared place. The gate tests evaluate the output's expression on the same three cases.automerge.MARKER.src/km/automerge.pyat the commit ci.yml pins.CI_APP_CLIENT_ID/CI_APP_PRIVATE_KEYin different environments. The names stay, since existing brains already hold them. Each header names the other App and links the section, and keeps the steps for its own App. A brain's copy then still describes itself at the km version it pins, and the pointers inkm doctor,km upgradeand the skill's setup reference stay true.after,at,fresh), and an unreadable time still counts as 0. Mutating the listing filter alone showed that no test failed, because the later check refused the run anyway. A test case now covers it: an older run is passed over and waited past.km upgradereplaces main's unchanged copies of all three.Left out
id: merge: kept. The workflow does not read it, buttests/automerge_smoke.shuses it to find the merge step (step act mergeand the token assertion).GITHUB_TOKENalready hascontents: write, so the App token gives no extra privilege during the re-checks. Its only difference is that its merge starts workflows. Splitting the step would put comment posting in two steps and widen the gap between the last re-read and the merge.__init__.py.resolveintodecidesaves one short job, and only for akm:readypull request, because the others stop inresolve. It would add a guard to eachdecidestep, and the e2e check that a push-ci run concludesskippedrelies on the job-levelif. The act and decide re-reads guard real races, and the stand-in tests pin their exact call counts.pr-opened-while-waiting,base-changed-while-waiting).Checks
appoutput (variable, merge term), act'sAPP, the token step'sif, and in approve-fork-ci each cutoff site separately (listing filter, page stop, unreadable time, pre-approval recheck,after).