Repository navigation
docs(skill): drop replayed sign-offs when a rebase moves the base under a signed-off doc - #105
Merged
Merged
Conversation
…er a signed-off doc A rebase onto a default branch that changed a doc the branch signs off replays sign-offs over text their approver never saw. The PR flow now says to drop those sign-off commits, review the merged text and sign it off once, dated today, and never to re-run km approve with the original approver or date. Refs #104.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #104 (proposal 1; proposals 2 and 3 are left out, see below).
A rebase onto a default branch that changed a doc the branch signs off replays sign-offs over text their approver never saw. The PR flow (step 3, review-and-pr.md) now says: detect it with
git diff --name-only <base> origin/<default> -- <doc>, drop the sign-off commits for that doc and for accepted docs linking to it,km demotewhere the new base has the doc accepted, then sign off once in step 4 without--at, and never re-runkm approvewith the original approver or date.Left out:
--atguard (proposal 2): a today-dated replay with the original--byis just as false, so the guard does not fix the cause; a history-based rule passes in exactly this case because a rebase keeps author dates. A today-only rule would mostly cost test changes (gate_smoke, signoff_smoke, e2e_smoke use fixed past dates). Can follow separately.Checks: skill_smoke and skill_inventory pass. One review pass (correctness and simplification) ran; its findings are applied (rebase target, km demote on an accepted base, replayed commits fail km validate rather than the hook, wording). Plugin evals not run yet.