Skip to content

docs(skill): drop replayed sign-offs when a rebase moves the base under a signed-off doc - #105

Merged
pasrom merged 1 commit into
mainfrom
docs/rebase-signoff
Nov 20, 2026
Merged

pasrom merged 1 commit into
mainfrom
docs/rebase-signoff

Conversation

@pasrom

@pasrom pasrom commented Nov 20, 2026

Copy link
Copy Markdown
Owner

Refs #104 (proposal 1; proposals 2 and 3 are left out, see below).

A rebase onto a default branch that changed a doc the branch signs off replays sign-offs over text their approver never saw. The PR flow (step 3, review-and-pr.md) now says: detect it with git diff --name-only <base> origin/<default> -- <doc>, drop the sign-off commits for that doc and for accepted docs linking to it, km demote where the new base has the doc accepted, then sign off once in step 4 without --at, and never re-run km approve with the original approver or date.

Left out:

  • --at guard (proposal 2): a today-dated replay with the original --by is just as false, so the guard does not fix the cause; a history-based rule passes in exactly this case because a rebase keeps author dates. A today-only rule would mostly cost test changes (gate_smoke, signoff_smoke, e2e_smoke use fixed past dates). Can follow separately.
  • validate reporting hand-edited approval fields (proposal 3): digest edits are already caught (approval-stale); approver or date under an unchanged digest have no trusted reference.

Checks: skill_smoke and skill_inventory pass. One review pass (correctness and simplification) ran; its findings are applied (rebase target, km demote on an accepted base, replayed commits fail km validate rather than the hook, wording). Plugin evals not run yet.

…er a signed-off doc

A rebase onto a default branch that changed a doc the branch signs off replays sign-offs over text their approver never saw. The PR flow now says to drop those sign-off commits, review the merged text and sign it off once, dated today, and never to re-run km approve with the original approver or date. Refs #104.
@pasrom
pasrom merged commit f9cffc4 into main Nov 20, 2026
5 checks passed
@pasrom
pasrom deleted the docs/rebase-signoff branch November 20, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant