Skip to content

[AI-FSSDK] [FSSDK-12958] Continue rule evaluation after local holdout hit - #640

Open
alexjoeyyong wants to merge 3 commits into
masterfrom
ai/alexjoeyyong/FSSDK-12958-local-holdout-flow-fix
Open

alexjoeyyong wants to merge 3 commits into
masterfrom
ai/alexjoeyyong/FSSDK-12958-local-holdout-flow-fix

Conversation

@alexjoeyyong

@alexjoeyyong alexjoeyyong commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

A local holdout hit used to return the holdout variation and stop evaluating the flag. Now it excludes the user from that rule only: the hit is recorded, the rule is skipped, and evaluation continues with the next experiment or delivery rule, so the user can still be served by a later rule.

Changes

  • Local holdout hits on experiment and delivery rules skip that rule and continue to the next rule, with no jump to "Everyone Else"
  • Each local holdout hit sends one holdout impression in the existing format, regardless of sendFlagDecisions; DISABLE_DECISION_EVENT suppresses them
  • Holdout hits are recorded in a new list on the feature decision; the existing holdout field is kept (deprecated) and holds the first hit, so the public API is unchanged
  • The final decision and its events are unchanged; global holdouts are unchanged

Jira Ticket

FSSDK-12958

@jaeopt jaeopt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants