Repository navigation
Make Archive.get_entry_by_id public and deprecate _get_entry_by_id - #274
Sriram-Nambiar wants to merge 1 commit into
Conversation
|
@Sriram-Nambiar please rebase on main and force push with lease, so that we have tests running on this PR |
b915f31 to
81f7dce
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #274 +/- ##
==========================================
+ Coverage 94.08% 94.12% +0.04%
==========================================
Files 1 1
Lines 541 545 +4
==========================================
+ Hits 509 513 +4
Misses 32 32 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@Sriram-Nambiar please immediately remove |
81f7dce to
27a87ec
Compare
benoit74
left a comment
benoit74
left a comment
There was a problem hiding this comment.
Please fix your first PR comment and the CHANGELOG below
|
|
||
| - Add a CI job building the documentation on every PR/push so this kind of breakage is caught automatically (#279) | ||
| - Add support for Python 3.15 (#281) | ||
| - Add `Archive.get_entry_by_id()` (#225) |
There was a problem hiding this comment.
No need for this extra entry, it is already obvious when reading the other CHANGELOG entry
There was a problem hiding this comment.
i have removed this extra entry and updated the pr
27a87ec to
b6dad96
Compare
This branch has not been deployed
2 participants
Fixes #225.
Archive.get_entry_by_id(entry_id).Archive._get_entry_by_id(entry_id).libzim/reader.pyi.tests/test_libzim_reader.py.