Repository navigation
Add test for Archive.get_entry_by_title with distinct title and title… - #273
Merged
Merged
Conversation
Contributor
|
@Sriram-Nambiar please rebase on main and force push with lease, so that we have tests running on this PR |
Sriram-Nambiar
force-pushed
the
test-get-entry-by-title
branch
from
October 22, 2026 13:18
db34ab2 to
055cbf8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #273 +/- ##
=======================================
Coverage 94.09% 94.09%
=======================================
Files 1 1
Lines 542 542
=======================================
Hits 510 510
Misses 32 32 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Sriram-Nambiar
force-pushed
the
test-get-entry-by-title
branch
from
October 22, 2026 13:52
055cbf8 to
fc084ac
Compare
benoit74
self-requested a review
October 25, 2026 17:33
benoit74
approved these changes
Oct 25, 2026
benoit74
force-pushed
the
test-get-entry-by-title
branch
from
October 25, 2026 17:33
fc084ac to
dd4aa9c
Compare
pawank925
pushed a commit
to pawank925/python-libzim
that referenced
this pull request
Oct 28, 2026
…title Add test for Archive.get_entry_by_title with distinct title and title…
pawank925
added a commit
to pawank925/python-libzim
that referenced
this pull request
Oct 28, 2026
…title Add test for Archive.get_entry_by_title with distinct title and title…
pawank925
added a commit
to pawank925/python-libzim
that referenced
this pull request
Oct 28, 2026
…title Add test for Archive.get_entry_by_title with distinct title and title…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #223.
Adds
test_get_entry_by_title_utf8intests/test_libzim_creator.pyto verify thatArchive.get_entry_by_title()resolves via the title index rather than path fallback.Covers:
KeyError