[drgrice1]

Existing test versions are not updated when problems are added, deleted, or reordered for a test, and that leaves those versions inconsistent with the set (see issues #1513 and #3234). Furthermore, updating student versions would change their test results. Now once users other than the current user have versions of a test, the controls for adding, deleting, and reordering problems are hidden on the set detail page and a notice is shown explaining why. Those changes are also rejected server side by the set detail page, by the problem editor's add to set actions, and by the addProblem and deleteProblem API commands. Changing the assignment type of such a set to or from jitar is also rejected since that renumbers the problems.

If the only versions of a test are those of the current user (e.g., an instructor working on creating the test), then these changes are allowed and the current user's versions are updated accordingly. Problems added to a set are now also added to existing versions of the set, deleting a problem now also deletes the corresponding problem versions, and reordering problems on the set detail page also reorders the problem versions.

The reorderProblems API command does not update user problems or problem versions, so it is rejected if any versions of the test exist.

The set detail help now has an "Editing Tests" entry that describes these restrictions and the quirks that can occur when an instructor edits a test they have already taken. In particular, answers previously entered in those versions are no longer shown with a problem whose number changes, since the answer names are prefixed with the problem number.

This is intended to address #3234 and #1513.

[pstaabp]

Looks good.

[somiaj]

I haven't fully tested this, but you mention you prevent changing to a JITAR set, but what happens to test versions if you change to a default homework set? I see that the set editor still detects versions exist and keeps one from deleting or changing problems, but the set versions are no longer accessible to students.

Maybe restrict changing sets to default assignments as well (only allow toggling between tests and proctored tests).

Would it also be useful to remove JITAR (and homework if you decided to restrict that too) from the list of assignment types so it is clearer it cannot be selected (or disabling it?) Though if the logic is a bit difficult here, might not be worth it.

[drgrice1]

The reasoning behind not allowing the switch to JITAR sets is that immediately renumbers problems (JITAR sets use a completely different numbering system). Switching to a default set does not cause that problem. Furthermore, once that switch is made the set is still restricted from adding, deleting, or reordering problems even though it is not a test anymore, since the only criterion for the restriction is that versioned sets exist, and they still do. Students cannot access those versions, but if the assignment is switched back to a test, then those versions are still there and still work. So that restriction is not needed.

[drgrice1]

This now does not allow switching a test that students have started to work to homework or JITAR. Those assignment types are disabled in the select, and the changes are rejected server side. So the only allowed changes to an in progress test assignment type are between proctored or not.