Repository navigation
Name the release line's branch for the GitHub release - #179
Merged
Merged
Conversation
JReleaser takes main as release.github.branch unless told otherwise, and before it opens a release it looks the branch up on GitHub. A branch that is not there it creates with git push --all, which from the tag's detached checkout has nothing to push. With main gone from GitHub, the draft release of 21.0.0 failed that way, "Could not checkout branch main", while Maven Central, the Gradle Plugin Portal and the JetBrains Marketplace got the version. The branch is now 21.X.X, the current release line; it moves when the next line starts, as target-branch does in dependabot.yml. A dry run skips the lookup, so only the next tag proves the fix; jreleaserConfig shows branch and branchPush as 21.X.X.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The 21.0.0 release (run 41307243703) reached Maven Central, the Gradle Plugin Portal and the JetBrains Marketplace, but its draft GitHub release failed with
Could not checkout branch main(Nothing to push). JReleaser takesmainasrelease.github.branchunless told otherwise, and before it opens a release it looks the branch up on GitHub. A branch that is not there it creates withgit push --all, which from the tag's detached checkout has nothing to push.mainis gone from GitHub since the move to 21.X.X.The fix
branch = '21.X.X'in the release conventions: the current release line, moved when the next line starts, astarget-branchis in dependabot.yml.Tests
A dry run skips the branch lookup, so only the next tag proves the fix.
jreleaserConfigwith-PreleaseTarget=githubnow showsbranch: 21.X.XandbranchPush: 21.X.X. 21.0.0 stays without a GitHub release: the next bugfix release, tagged after this merge, takes its place.