Repository navigation
fix(actionlint): build with the latest stable Go - #53
Open
kojiromike wants to merge 1 commit into
Open
kojiromike wants to merge 1 commit into
kojiromike wants to merge 1 commit into
Conversation
The setup-go action previously read go 1.25.0 from the fork's go.mod and installed exactly Go 1.25.0. That release is past end of support. Running govulncheck on a 1.25.0 build of v1.7.12-oce.3 finds three standard-library vulnerabilities actionlint's code reaches. These are GO-2026-4602 (os), GO-2026-4601 and GO-2025-4010 (net/url). Go 1.25.8 or later fixes them. No Dependabot alert covers the toolchain. The action now uses a stable go-version so it builds actionlint with the latest stable Go. We built v1.7.12-oce.3 with Go 1.27.4 (current stable) to test. Running govulncheck -mode=binary finds no vulnerabilities and the binary lints this repo's workflows clean. There is no matrix, because a matrix would rename the job's check, which consumers may require. Consumers pick this up through Dependabot when this repo releases. Assisted-by: Claude Code
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After merge, the release-please PR cuts the next version. Consumers then get Dependabot PRs for the new tag.
This updates the reusable workflow to build actionlint with the latest stable Go. The setup-go action previously installed the exact Go version from the fork's go.mod file. That version is 1.25.0. It is out of support and has three reachable standard library vulnerabilities. These are GO-2026-4602, GO-2026-4601, and GO-2025-4010. Dependabot alerts do not cover toolchains, so we found this using govulncheck during the org Dependabot alert sweep.
Using
stablemeans the version floats, so each new Go release arrives without a PR. Pinning a minor version like 1.27 would need hand bumps since Dependabot does not see it.Separate from this, consumers' pre-commit hooks still pin v1.7.12-oce.1 and build with the developer's local Go.
Tested: v1.7.12-oce.3 built with Go 1.27.4. Running
govulncheck -mode=binaryis clean, and the binary lints this repo clean.