Repository navigation
feat(helm): date label-sourced releases from object metadata - #176
Merged
Merged
Conversation
Releases found with --release-source labels had zero first/last deployed times, so the installed date in the output was 0001-01-01. Take first deployed from the earliest creation time of the release's objects and last deployed from the latest managedFields time written by the helm field manager, falling back to first deployed when no helm write is recorded.
There was a problem hiding this comment.
Code Review
This pull request adds deployment date tracking for label-sourced Helm releases by capturing the earliest creation time of the release's objects as 'FirstDeployed' and the latest update time by the 'helm' field manager as 'LastDeployed'. It updates the internal structures, implements helper functions to parse managed fields, and includes unit tests verifying this behavior. There are no review comments, and I have no feedback to provide.
RamanKharchee
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Releases found with
--release-source labelshad zero first/last deployed times, so the installed date innova findoutput was0001-01-01T00:00:00Z.managedFieldstime written by thehelmfield manager on any of those objects. Helm writes it on install and on each upgrade that changes the object. When no helm write is recorded, it falls back to first deployed.Type of change
How Has This Been Tested?
How to verify: run
nova find --release-source labels --format jsonand check that each release'sInstalled.dateis a real timestamp, not0001-01-01T00:00:00Z.Engineering detail
helmmanagedFields time.go test ./...andgolangci-lint runare clean.Local e2e: ran the built binary against a real multi-release cluster while impersonating a service account without Secrets access. Before: all 37 releases had
0001-01-01. After: none did, and 27 of 37 installed dates fell on the same day as Helm's own last-deployed time from the Secrets source; the other 10 were earlier, as described above.Checklist