Skip to content

test: convert .forEach to for...of - #67124

Open
JPeer264 wants to merge 1 commit into
nodejs:mainfrom
JPeer264:jp/convert-test
Open

test: convert .forEach to for...of#67124
JPeer264 wants to merge 1 commit into
nodejs:mainfrom
JPeer264:jp/convert-test

Conversation

@JPeer264

@JPeer264 JPeer264 commented Oct 29, 2026

Copy link
Copy Markdown
Member

This converts the test to the preferred for...of style

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Oct 29, 2026
@JPeer264
test: convert .forEach to for...of
cf5990f 
Signed-off-by: JPeer264 <jan.peer@sentry.io>
@Ethan-Arrowood Ethan-Arrowood added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 29, 2026
Ethan-Arrowood
Ethan-Arrowood approved these changes Oct 29, 2026
View reviewed changes

@Ethan-Arrowood Ethan-Arrowood left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐢

@codecov

codecov Bot commented Oct 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.66%. Comparing base (502c117) to head (cf5990f).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #67124   +/-   ##
=======================================
  Coverage   90.66%   90.66%           
=======================================
  Files         797      797           
  Lines      278791   278791           
  Branches    53620    53615    -5     
=======================================
+ Hits       252768   252770    +2     
+ Misses      16376    16374    -2     
  Partials     9647     9647

see 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Ethan-Arrowood Ethan-Arrowood added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 30, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 30, 2026
@nodejs-github-bot

nodejs-github-bot commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/78730/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JPeer264 @nodejs-github-bot @Ethan-Arrowood