Repository navigation
chore: fix the QA drift and drop the v from release names - #7
Merged
Merged
Conversation
QA on main has been failing since the tool versions moved: Rector asks for ??= in CliHandler and CliResponse, and ECS removes docblocks that only repeat the test name, two null defaults and a redundant @PARAM. No behavior change.
… catch PHPStan flagged the catch (ErrorException) as never thrown: it doesn't know the error handler turned warnings into exceptions. The handler now records the message emitted by unserialize(), and the bootstrap throws the same exception right after.
Tags are already created without it. include-v-in-release-name is supported by release-please 17.6.0, the version bundled by the pinned action.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7 +/- ##
============================================
- Coverage 92.51% 92.49% -0.02%
+ Complexity 565 562 -3
============================================
Files 16 16
Lines 1322 1319 -3
============================================
- Hits 1223 1220 -3
Misses 99 99 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…ormat ECS 13.3 removed the checkstyle output format, so the pinned version of the shared workflow piped the console output into cs2pr and failed even though ECS reported no error. nlemoine/.github fixed it in 05f8fcc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QA on
mainhas been red since the tool versions moved (first failing run ond68cc7c, before the security fixes): Rector, ECS and PHPStan. Tests were green on every PHP version.??=inCliHandlerandCliResponse, no behavior change.ClientTest, two null defaults and a redundant@paraminInputStream.catch (ErrorException)in the bootstrap was never reached, since PHPStan doesn't know the error handler turned warnings into exceptions. The handler now records the message fromunserialize()and the same exception is thrown right after.include-v-in-release-name: false, so release names match the tags (1.1.2rather thanv1.1.2). Supported by release-please 17.6.0, the version bundled by the pinned action.742 tests pass locally; PHPStan, ECS and Rector are clean.