Skip to content

nirfsa enum and template fixes - #2236

Merged
vnktshr21 merged 2 commits into
ni:masterfrom
mohit-emerson:metadata_cleanup
Oct 23, 2026
Merged

vnktshr21 merged 2 commits into
ni:masterfrom
mohit-emerson:metadata_cleanup

Conversation

@mohit-emerson

Copy link
Copy Markdown
Contributor
  • This contribution adheres to CONTRIBUTING.md.
  • [] I've updated CHANGELOG.md if applicable.
  • [ ] I've added tests applicable for this pull request

What does this Pull Request accomplish?

  • Fix some enum values to correct corresponding integer values
  • Fix enum values NONE to NONE_STR
  • Template white space changes

List issues fixed by this Pull Request below, if any.

None

What testing has been done?

PR Validations

@codecov-commenter

codecov-commenter commented Oct 23, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.19608% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.12%. Comparing base (0c551d6) to head (890529f).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
generated/nirfsa/nirfsa/session.py 83.33% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2236   +/-   ##
=======================================
  Coverage   88.12%   88.12%           
=======================================
  Files          88       88           
  Lines       22832    22830    -2     
=======================================
- Hits        20120    20119    -1     
+ Misses       2712     2711    -1     
Flag Coverage Δ
codegenunittests 84.78% <ø> (ø)
nidcpowersystemtests 94.40% <ø> (+0.04%) ⬆️
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests 92.04% <ø> (ø)
nidigitalunittests 68.43% <ø> (ø)
nidmmsystemtests 92.33% <ø> (ø)
nifakeunittests 86.08% <ø> (ø)
nifgensystemtests 94.34% <ø> (ø)
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests 94.20% <ø> (ø)
nirfsasystemtests 82.71% <83.33%> (ø)
nirfsaunittests 63.37% <43.13%> (-0.03%) ⬇️
nirfsgsystemtests 81.22% <ø> (ø)
niscopesystemtests 89.99% <ø> (ø)
niscopeunittests 43.20% <ø> (ø)
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 81.66% <ø> (ø)
nitclksystemtests 94.87% <ø> (ø)
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vnktshr21 vnktshr21 changed the title nirfsa Metadata cleanup nirfsa enum and template fixes Oct 23, 2026
@vnktshr21
vnktshr21 merged commit 609c4ee into ni:master Oct 23, 2026
54 of 58 checks passed
@ni-jfitzger

Copy link
Copy Markdown
Collaborator

@mohit-emerson @vnktshr21 You guys changed the name of an enum value and didn't update the changelog?
This looks like a breaking change, to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants