Skip to content

Adding TMU support for NI-Digital - #2230

Open
elebel-emerson wants to merge 7 commits into
ni:masterfrom
elebel-emerson:users/elebel/updatingNiDigitalMetadata
Open

elebel-emerson wants to merge 7 commits into
ni:masterfrom
elebel-emerson:users/elebel/updatingNiDigitalMetadata

Conversation

@elebel-emerson

@elebel-emerson elebel-emerson commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor
  • This contribution adheres to CONTRIBUTING.md.

  • I've updated CHANGELOG.md if applicable.

  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

Update metadata to latest 27.0 export for NI-Digital
Added some tests making sure function calls and enums work for TMU capabilities
Resulting Changes:

  • nidigital has some documentation changes (mostly/all? adding tmu to documentation)

List issues fixed by this Pull Request below, if any.

none

What testing has been done?

PR Checks

@codecov-commenter

codecov-commenter commented Oct 21, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.75510% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.07%. Comparing base (cdbd8f2) to head (3dd0bd5).
⚠️ Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
generated/nidigital/nidigital/session.py 87.75% 6 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (cdbd8f2) and HEAD (3dd0bd5). Click for more details.

HEAD has 76 uploads less than BASE
Flag BASE (cdbd8f2) HEAD (3dd0bd5)
nifakeunittests 15 5
nidcpowerunittests 15 5
nidigitalunittests 15 5
nimodinstunittests 15 5
nirfsaunittests 15 4
niscopeunittests 15 4
nitclkunittests 15 4
codegenunittests 3 1
nidigitalsystemtests 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2230      +/-   ##
==========================================
- Coverage   88.11%   82.07%   -6.04%     
==========================================
  Files          88       83       -5     
  Lines       22832    20890    -1942     
==========================================
- Hits        20119    17146    -2973     
- Misses       2713     3744    +1031     
Flag Coverage Δ
codegenunittests 84.78% <ø> (ø)
nidcpowersystemtests 85.18% <ø> (-9.18%) ⬇️
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests ?
nidigitalunittests 69.48% <87.75%> (+1.05%) ⬆️
nidmmsystemtests 81.16% <ø> (-11.17%) ⬇️
nifakeunittests 86.08% <ø> (ø)
nifgensystemtests 84.75% <ø> (-9.59%) ⬇️
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests 94.20% <ø> (ø)
nirfsasystemtests 72.44% <ø> (-10.28%) ⬇️
nirfsaunittests 63.37% <ø> (-0.03%) ⬇️
nirfsgsystemtests 81.22% <ø> (+0.03%) ⬆️
niscopesystemtests 82.08% <ø> (-7.91%) ⬇️
niscopeunittests 43.20% <ø> (ø)
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 81.66% <ø> (ø)
nitclksystemtests 94.87% <ø> (ø)
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@elebel-emerson
elebel-emerson marked this pull request as ready for review October 21, 2026 20:54
@ni-jfitzger

ni-jfitzger commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

"Update metadata for nidigital" is a very vague PR title.
Aren't you adding TMU support?



class HistoryRAMMaxSamplesToAcquirePerSite(Enum):
SAMPLES = -1

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something feels off about this enum. If nothing else, the value name "SAMPLES" feels like a terrible name.

Is this ENUM even needed?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something must be off with the codegen for us to be trimming the rest of value name.
I'm really not sure we want to add this to the API.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently, _add_enum_value_python_name strips everything through the last underscore when there's only one value.
Seems like a codegen bug.
If we fix the name, I can accept this enum addtion. I don't know how @marcoskirsch feels about it.

Comment thread src/nidigital/metadata/attributes.py
@elebel-emerson elebel-emerson changed the title Update metadata for nidigital Adding TMU support for NI-Digital Oct 22, 2026
@elebel-emerson

Copy link
Copy Markdown
Contributor Author

"Update metadata for nidigital" is a very vague PR title. Aren't you adding TMU support?

Both, functionally I am updating to the latest metadata that has TMU support, but yes this change is being done to add TMU support. Changed the name to better describe the why and not the how.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants