Repository navigation
Adding TMU support for NI-Digital - #2230
elebel-emerson wants to merge 7 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2230 +/- ##
==========================================
- Coverage 88.11% 82.07% -6.04%
==========================================
Files 88 83 -5
Lines 22832 20890 -1942
==========================================
- Hits 20119 17146 -2973
- Misses 2713 3744 +1031
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
"Update metadata for nidigital" is a very vague PR title. |
|
|
||
|
|
||
| class HistoryRAMMaxSamplesToAcquirePerSite(Enum): | ||
| SAMPLES = -1 |
There was a problem hiding this comment.
Something feels off about this enum. If nothing else, the value name "SAMPLES" feels like a terrible name.
Is this ENUM even needed?
There was a problem hiding this comment.
Something must be off with the codegen for us to be trimming the rest of value name.
I'm really not sure we want to add this to the API.
There was a problem hiding this comment.
Apparently, _add_enum_value_python_name strips everything through the last underscore when there's only one value.
Seems like a codegen bug.
If we fix the name, I can accept this enum addtion. I don't know how @marcoskirsch feels about it.
Both, functionally I am updating to the latest metadata that has TMU support, but yes this change is being done to add TMU support. Changed the name to better describe the why and not the how. |
This contribution adheres to CONTRIBUTING.md.
I've updated CHANGELOG.md if applicable.
I've added tests applicable for this pull request
What does this Pull Request accomplish?
Update metadata to latest 27.0 export for NI-Digital
Added some tests making sure function calls and enums work for TMU capabilities
Resulting Changes:
List issues fixed by this Pull Request below, if any.
none
What testing has been done?
PR Checks