Repository navigation
fix(menu): make component actions work from the remaining actions menu - #9467
Merged
Merged
Conversation
grnd-alt
approved these changes
Oct 26, 2026
silverkszlo
force-pushed
the
fix/toolbar-remaining-actions
branch
from
October 26, 2026 12:59
6cc4a9a to
fbdf12a
Compare
blizzz
reviewed
Oct 26, 2026
Collaborator
Author
|
failing playwright and cypress tests are unrelated |
blizzz
approved these changes
Oct 26, 2026
Signed-off-by: silver <s.szmajduch@posteo.de> Assisted-by: ClaudeCode:claude-opus-5.5
Signed-off-by: silver <s.szmajduch@posteo.de> Assisted-by: ClaudeCode:claude-opus-5.5
blizzz
force-pushed
the
fix/toolbar-remaining-actions
branch
from
October 26, 2026 19:49
fbdf12a to
b8a4161
Compare
Collaborator
Author
|
/backport to stable35 |
Collaborator
Author
|
/backport to stable34 |
Collaborator
Author
|
/backport to stable33 |
Collaborator
Author
|
/backport to stable32 |
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
The bug
In the mobile app (or on mobile view in the browser) the menu/toolbar items
Insert link,Insert attachment,Insert emojiandNextcloud Assistantdon't work.To reproduce
Insert emojiorInsert attachmentor one of the other mentioned optionsInsert emojigives "undefined" text on editor page,Insert attachmentand the rest do nothingSolution
Entries rendered by their own component (
insert link, insert attachment, emoji picker, assistant) had no working action in the 3-dot menu. Clicking them now moves the entry into the menu bar and opens it there.Also show the emoji picker on mobile devices and fix duplicate keys in the remaining actions menu.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)🤖 AI (if applicable)